Skip to content

chore: fix JavaScript lint errors (issue #10084)#10087

Merged
kgryte merged 3 commits intostdlib-js:developfrom
Kayd-06:fix/lint-asinh-by-10084
Apr 10, 2026
Merged

chore: fix JavaScript lint errors (issue #10084)#10087
kgryte merged 3 commits intostdlib-js:developfrom
Kayd-06:fix/lint-asinh-by-10084

Conversation

@Kayd-06
Copy link
Copy Markdown
Contributor

@Kayd-06 Kayd-06 commented Feb 5, 2026

resolves #10084

Description

What is the purpose of this pull request?

This pull request:

  • Replaced the new Array() constructor with an array literal and a loop in [test/test.main.js] to satisfy the stdlib/no-new-array linting rule.
  • Populates the array with void 0 to maintain the intended structure of the tests.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used it for understanding the issue and codebase but the changes were done manually.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. labels Feb 5, 2026
@MANDEep22332 MANDEep22332 mentioned this pull request Mar 13, 2026
Merged
7 tasks
Planeshifter pushed a commit that referenced this pull request Mar 16, 2026
@MANDEep22332
chore: fix JavaScript lint errors
a410628 
PR-URL: #10909
Closes: #10906
Ref: #10087

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 10, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 10, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 10, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 10, 2026
@kgryte
style: disable lint rule
0c221a8 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte mentioned this pull request Apr 10, 2026
Closed
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 10, 2026

Coverage Report

Package Statements Branches Functions Lines
math/strided/special/asinh-by $\color{green}197/197$
$\color{green}+100.00%$ 		$\color{green}5/5$
$\color{green}+100.00%$ 		$\color{green}2/2$
$\color{green}+100.00%$ 		$\color{green}197/197$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte merged commit 1fa7f29 into stdlib-js:develop Apr 10, 2026
29 checks passed
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 10, 2026

Thank you for your contribution and congratulations on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Potential Duplicate There might be another pull request resolving the same issue. review: 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@Kayd-06 @kgryte @stdlib-bot